noscript elements are incorrectly identified as relevant text
Reported by rziai | September 21st, 2008 @ 09:59 PM | in 0.2
-
Firefox doesn't include elements in the DOM
-
GWT modules walk over all the spans and get them by id
-
As soon as a call returns null, that's it.
-
As soon as we encounter a noscript with a marked up span inside, the loop terminates (incorrectly).
Comments and changes to this ticket
-
adimit September 22nd, 2008 @ 02:14 AM
- Assigned user set to “adimit”
- State changed from “new” to “open”
- Tag set to “enhancement, gwt, interface”
For a testcase, see:
http://news.bbc.co.uk/2/hi/afric...
I can imagine several solutions to this.
- A stupid one would be just ignoring in the RelevantText annotator.
- Slightly more involved would be finding a way of getting a collection of items with a given class attribute via the DOM. I don't know if this is doable, and will have to look into it.
-
nott September 22nd, 2008 @ 10:45 AM
If we ignore stuff inside we might fool users who do not have JavaScript switched on. Which we do anyways with GWT, don't we? So if we insist in JS anyways, we can as well make the RelevantText annotator ignore these passages.
-
adimit September 22nd, 2008 @ 02:40 PM
- Milestone set to “0.2”
Exactly, but the problem is that,
- I'm not content with this ID-thing anyways. As we have seen, it's error prone, and, moreover, it's inefficient (just color-tagging spans is more efficient for the user. But it's also less flexible, as enhancements can now use GWT widgets.)
- If we ignore the <noscript> tag that will solve the issue, but probably there are more quirks we'd have to watch out for.
So, it's probably best to overhaul the whole process, but I've not investigated on this yet. For now, ignoring <noscript> might be a feasible solution.
-
nott September 22nd, 2008 @ 07:08 PM
The IDs are OK. What's not OK is that the loop populating the spans with GWT widgets stops as soon as it misses one single span. Some testing revealed that this happens quite often.
If we could just step over those, this would greatly improve functionality. However, once it comes to FIB, we may find that a student did not fill in all questions and react to that, e.g. by popping up a message - even though he or she filled in everything visible on the screen.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A platform for aiding second language learners through texts acquired from the Internet.
adimit
nott